fix: issue with BTC transfer summary screen details visibility #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
force-pushed
the
fix/btc-transfer-summary-details
branch
from
237f1cd to
ff37416
Compare
pete-watters
force-pushed
the
fix/btc-transfer-summary-details
branch
from
ff37416 to
0f29502
Compare
kyranjamie
reviewed
Dec 19, 2023
| @@ -56,7 +56,7 @@ export function BtcSentSummary() { | |||
| useRouteHeader(<ModalHeader hideActions defaultClose title="Sent" />); | |||
|
|
|||
| return ( | |||
| <InfoCard> | |||
| <InfoCard height="110%"> | |||
There was a problem hiding this comment.
I don't think we want to add a height value like this
|
Thanks for your help with this @Nithishvb . Your change does indeed fix the bug temporarily but the root cause is actually a bigger issue with our page layouts. I have been working on that so I will include a change for that there. In general we don't want to set dimensions outside of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4714
This PR addresses and resolves an issue where details on the BTC transfer summary screen were not visible. The lack of visibility was negatively impacting the user experience.